Repository navigation
Value buttons for discrete numeric values: Range step, and numeric Values lists - #7
Merged
Merged
Conversation
…lues lists Per UX feedback: - "Range: [20-120, by 20]" allows only 20,40,...,120 (int or float). - An all-numeric "Values: [8,9,10,12,16]" lists the allowed values themselves (text labels still map to 0,1,2... in a dropdown). - When there are 21 or fewer allowed values, the detail pane shows a wrapping grid of buttons instead of the text box; the selected one is highlighted, and Apply & Save writes it. Typed values (when there are more than 21) are validated against the step / list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KaEsnLMDyw72GZ8a6ZxAGq
Per CLAUDE.md: values already in the cfg files that are out of range, off the step grid, not in a Values list, or invalid feature-flag strings are kept as they are, but highlighted: a warning icon (with tooltip) next to the value in the list, and a warning line per offending value (Default, User.cfg, VR.cfg) in the detail pane. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KaEsnLMDyw72GZ8a6ZxAGq
Path has no FillRule property (it belongs to the geometry), so the style setter failed the XAML compile (MC4005). Use the "F0" (even-odd) prefix in the path data instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KaEsnLMDyw72GZ8a6ZxAGq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows UX feedback. When a param allows only a small set of numbers, the user now picks one from a grid of buttons instead of typing it. Values already in the files that break a param's constraints are now flagged with a warning.
Description syntax
Range: [20-120, by 20]allows only 20, 40, 60, 80, 100 and 120. It works for integer and float params, e.g.Range: [0.5-2.0, by 0.25]. A step needs a minimum. A step with no maximum, e.g.[0-, by 5], is still enforced when values are typed, but shows no buttons.Values: [8,9,10,12,16]: when every entry is a number, these are the allowed values themselves, for integer and float params. When the entries are text, e.g.Values: [Low,Medium,High], they still label the values 0, 1 and 2 in the dropdown, as before.UI
ParamConstraints.MaxChoices), the detail pane shows a wrapping row of buttons in place of the text box, as in the mockup. The selected button gets the accent fill. Clicking a button stages the value, and Apply & Save writes it. Fill with default selects the default's button.1.0,0.75). A current value that doesn't match any button, e.g. one edited by hand, leaves no button selected.Values: 8, 9, 10, 12, 16) and shows the step in the range (Range: [20 to 120, by 20]).Warnings for existing values (CLAUDE.md: "highlight that condition")
Values already in the files are never changed. They're flagged when they're:
Valueslist,How they're shown:
Testing
Valueslists for integers (font sizes) and floats (the mockup's0.5, 0.75, 1.0, 1.5, 2.0).🤖 Generated with Claude Code
https://claude.ai/code/session_01KaEsnLMDyw72GZ8a6ZxAGq